Change RBAC cloud-controller-manager name #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changed the name of the rke2
cloud-controller-manager
clusterrole torke2-cloud-controller-manager
to prevent conflicts with other external cloud providers role names.Types of Changes
Bugfix
Verification
Spin up standard rke2 server:
kubectl get clusterrolebinding
should now outputrke2-cloud-controller-manager
as a ClusterRoleBindingkubectl get clusterrole
should now outputrke2-cloud-controller-manager
as a ClusterRoleLinked Issues
#1009 Is the open RKE2 issue
k3s-io/k3s#3308 Is the K3s issue that triggered this change
k3s-io/k3s#3388 Is the PR associated with the K3s issue
Further Comments